Allon Mureinik has posted comments on this change. Change subject: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu. ......................................................................
Patch Set 1: Looks good to me, approved mkublin - I missed the if checking imageGroup in line 790. Agree with your analysis and solution. Regarding optimizations - I agree the best optimization is not to run the query :-). The varchar<->UUID issue may be worth revisiting in additional patches, for where the queries cannot be removed, but obviously, this is not the scope. -- To view, visit http://gerrit.ovirt.org/9468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
