Allon Mureinik has posted comments on this change.

Change subject: engine: Query getdisksvmguid caused postmaster processes to 
consume constantly 100%cpu.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I have two questions that bother me here:

1. We are changing the flow - before this patch we only updated statistics on 
images (not LUN disks), and after the patch we update statistics on all the 
disk. This may be the correct behaviour, but let's discuss.

2. From the BZ, it seems that the UUID is passed as a VARCHAR literal. This may 
interfere with performing index scans, which could explain the long query 
durations. Was this direction explored?

--
To view, visit http://gerrit.ovirt.org/9468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to