Mike Kolesnik has posted comments on this change. Change subject: engine: Internal VmNic Information (WIP) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInterfaceDynamic.java Line 16: Line 17: /** Line 18: * The vNic's IPv4 addresses Line 19: */ Line 20: String ipv4Addresses; I disagree, I think the modelling should be correct and Object Oriented. The fact that you're saving it in the DB in one way or another is an implementation detail which should not be exposed in the API. The correct way to represent a collection of elements, is, well, a collection.. The element class could be String although I would favour a more OO approach. The UI can do whatever they want with it, I don't agree that we should base API design solely on hypothetical use in only one client of the system, which you can't even say for sure it is the only way this field will be used there. Line 21: Line 22: /** Line 23: * The vNic's IPv6 addresses Line 24: */ -- To view, visit http://gerrit.ovirt.org/9424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ffbbb96826c5dca8e4c9cdcddbe122c3523960 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
