Moti Asayag has posted comments on this change. Change subject: engine: Internal VmNic Information (WIP) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInterfaceDynamic.java Line 16: Line 17: /** Line 18: * The vNic's IPv4 addresses Line 19: */ Line 20: String ipv4Addresses; The most ordinary use of this field is as string. This field is mostly for data representation rather than being applicatively used. Therefore I don't see any case for storing it in a list. It will require several non-equired casts (read from db/save for db), UI will have to convert it into string as well... Line 21: Line 22: /** Line 23: * The vNic's IPv6 addresses Line 24: */ -- To view, visit http://gerrit.ovirt.org/9424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ffbbb96826c5dca8e4c9cdcddbe122c3523960 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
