Yair Zaslavsky has posted comments on this change. Change subject: engine: Fixing a possible bug at SPM election ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java Line 596: return null; Line 597: } Line 598: Line 599: List<VDS> prioritizedVdsInPool = GetPrioritizedVdsInPool(); Line 600: mCurrentVdsId = null; When I look at the first line of GetPrioritizedVdsInPool() , I see it repeats the way curVdsId is set. But it's not the only place in code that calls it - see getHasVdssForSpmSelection(). Line 601: Line 602: // If VDS is in initialize status, wait for it to be up (or until Line 603: // configurable timeout is reached) Line 604: WaitForVdsIfIsInitializing(curVdsId); -- To view, visit http://gerrit.ovirt.org/9309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dfbb3a59c22e1b4ce39c996e159e1fd5047475 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
