Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: add advanced parameters to VM Interface dialog
......................................................................
webadmin: add advanced parameters to VM Interface dialog
- Add advanced parameters section to VM Interface dialog
- "port mirroring" and "activate" should be moved to the advanced parametrs
section.
Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
2 files changed, 27 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/9310/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
index 1410dca..0ea368b 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java
@@ -5,6 +5,7 @@
import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
import org.ovirt.engine.ui.common.idhandler.WithElementId;
import org.ovirt.engine.ui.common.widget.Align;
+import org.ovirt.engine.ui.common.widget.dialog.AdvancedParametersExpander;
import org.ovirt.engine.ui.common.widget.editor.EntityModelCheckBoxEditor;
import org.ovirt.engine.ui.common.widget.editor.EntityModelTextBoxEditor;
import org.ovirt.engine.ui.common.widget.editor.ListModelListBoxEditor;
@@ -23,6 +24,7 @@
import com.google.gwt.user.client.ui.CheckBox;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.Panel;
public class NetworkInterfacePopupWidget extends
AbstractModelBoundPopupWidget<VmInterfaceModel> {
@@ -76,14 +78,23 @@
@Ignore
Label macExample;
- @UiField(provided=true)
+ @UiField(provided = true)
@Path("Active.entity")
@WithElementId("activate")
protected EntityModelCheckBoxEditor activateCheckBox;
+ @UiField
+ @Ignore
+ AdvancedParametersExpander expander;
+
+ @UiField
+ @Ignore
+ Panel expanderContent;
+
public NetworkInterfacePopupWidget(EventBus eventBus,
CommonApplicationConstants constants) {
initManualWidgets();
initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
+ expander.initWithContent(expanderContent.getElement());
localize(constants);
ViewIdHandler.idHandler.generateAndSetIds(this);
Driver.driver.initialize(this);
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
index ef91e14..43879d6 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
@@ -12,20 +12,32 @@
float: right;
}
+ .expanderContent {
+ padding-left: 10px;
+ float: left;
+ }
+
+ .expander {
+ margin-top:15px;
+ }
+
</ui:style>
<g:FlowPanel>
<e:EntityModelTextBoxEditor ui:field="nameEditor" />
<e:ListModelListBoxEditor ui:field="networkEditor" />
<e:ListModelListBoxEditor ui:field="nicTypeEditor" />
- <e:EntityModelCheckBoxEditor ui:field="portMirroringEditor" />
<g:HorizontalPanel>
<g:CheckBox ui:field="enableManualMacCheckbox"
addStyleNames="isTemplatePrivateEditor" />
<g:Label ui:field="enableManualMacCheckboxLabel" />
</g:HorizontalPanel>
<e:EntityModelTextBoxEditor ui:field="MACEditor" />
- <g:Label ui:field="macExample"
addStyleNames="{style.macExample}" text="{constants.exampleInterfacePopup}
00:14:4a:23:67:55" />
- <e:EntityModelCheckBoxEditor ui:field="activateCheckBox"/>
+ <g:Label ui:field="macExample"
addStyleNames="{style.macExample}" text="{constants.exampleInterfacePopup}
00:14:4a:23:67:55" />
+ <d:AdvancedParametersExpander ui:field="expander"
addStyleNames="{style.expander}"/>
+ <g:FlowPanel ui:field="expanderContent"
addStyleNames="{style.expanderContent}">
+ <e:EntityModelCheckBoxEditor
ui:field="portMirroringEditor" />
+ <e:EntityModelCheckBoxEditor
ui:field="activateCheckBox"/>
+ </g:FlowPanel>
</g:FlowPanel>
</ui:UiBinder>
--
To view, visit http://gerrit.ovirt.org/9310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
