Michael Kublin has uploaded a new change for review. Change subject: engine: Fixing a possible bug at SPM election ......................................................................
engine: Fixing a possible bug at SPM election The mCurrentVdsId should be set to null after GetPrioritizedVdsInPool(), because it used there Change-Id: I44dfbb3a59c22e1b4ce39c996e159e1fd5047475 Signed-off-by: Michael Kublin <mkub...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/9309/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java index a42b4b9..13edcbc 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java @@ -589,7 +589,6 @@ _isSpmStartCalled = false; String returnValue = null; Guid curVdsId = (mCurrentVdsId != null) ? mCurrentVdsId : Guid.Empty; - mCurrentVdsId = null; storage_pool storagePool = DbFacade.getInstance().getStoragePoolDao().get(_storagePoolId); if (storagePool == null) { @@ -598,6 +597,7 @@ } List<VDS> prioritizedVdsInPool = GetPrioritizedVdsInPool(); + mCurrentVdsId = null; // If VDS is in initialize status, wait for it to be up (or until // configurable timeout is reached) -- To view, visit http://gerrit.ovirt.org/9309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44dfbb3a59c22e1b4ce39c996e159e1fd5047475 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches