Vered Volansky has posted comments on this change.
Change subject: core: Extract disk alias generation methods
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/disks/DiskUtils.java
Line 23: * If the disk does not already have an alias, one will be
generated for it.
Line 24: *
Line 25: * @param disk
Line 26: * - Disk which disk alias is being initialized in.
Line 27: * @param diskPrefix
This is not English, while you're at it why not rephrase?
Line 28: * - The prefix for disk alias if needs to be
initialized.
Line 29: * @return The suggested alias
Line 30: */
Line 31: public static String getSuggestedDiskAlias(BaseDisk disk, String
diskPrefix, int count) {
....................................................
Commit Message
Line 11:
Line 12: This was done for two reasons:
Line 13: * These methods were in the wrong place - disk aliases are used for all
Line 14: disks, not just images.
Line 15: * To allow these methods to be used outside of the bll package, e.g.,
s/in//
Line 16: in by the OVF handling classes (see next patch).
Line 17:
Line 18: This patch contains:
Line 19: * The new DiskUtils class with the getSuggestedDiskAlias,
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
