Michael Pasternak has posted comments on this change. Change subject: [WIP] Adding system information to getCapabilities from host ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) +1, looks good for api, except tiny comment in api.xsd. .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1084: <xs:element name="bios_information" type="BiosInformation"/> Line 1085: Line 1086: <xs:complexType name="BiosInformation"> Line 1087: <xs:sequence> Line 1088: <xs:element name="manufacturer" type="xs:string" minOccurs="0" maxOccurs="1"/> didn't we agreed to call it ^ 'origin'? or am i confusing with something else? Line 1089: <xs:element name="version" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1090: <xs:element name="serial_number" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1091: <xs:element name="product_name" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1092: <xs:element name="uuid" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/9337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
