Moti Asayag has posted comments on this change. Change subject: engine: Add Vds Port Validation 65535 (#871328) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java Line 77: private String hostname; Line 78: Line 79: @Min(value = BusinessEntitiesDefinitions.HOST_MIN_LEGAL_PORT, message = "VALIDATION.VDS.PORT.RANGE") Line 80: @Max(value = BusinessEntitiesDefinitions.HOST_MAX_LEGAL_PORT, message = "VALIDATION.VDS.PORT.RANGE") Line 81: @Column(name = "port") Can you use org.hibernate.validator.constraints.Range instead ? Line 82: private int port; Line 83: Line 84: @Column(name = "vds_group_id") Line 85: @Type(type = "guid") -- To view, visit http://gerrit.ovirt.org/9149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
