Moti Asayag has posted comments on this change.
Change subject: engine: Change Max Port Number to 65535 (#871328)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 308: returnValue = false;
Line 309: } else if
(!IsPowerManagementLegal(getParameters().getVdsStaticData(), getVdsGroup()
Line 310: .getcompatibility_version().toString())) {
Line 311: returnValue = false;
Line 312: } else if
(getParameters().getVdsStaticData().getport() < MIN_LEGAL_PORT
Although it is already implemented as a can-do-action it could be extracted to
a validation on the port field.
Line 313: ||
getParameters().getVdsStaticData().getport() > MAX_LEGAL_PORT) {
Line 314:
addCanDoActionMessage(VdcBllMessages.VDS_PORT_IS_NOT_LEGAL);
Line 315: returnValue = false;
Line 316: } else {
--
To view, visit http://gerrit.ovirt.org/9149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
