Maor Lipchuk has posted comments on this change.
Change subject: core: Fix run VM with locked disk msg
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 512: }
Line 513: return returnValue;
Line 514: }
Line 515:
Line 516: private static void addDiskLockedMessage(List<String>
lockedDisksAliases, List<String> messages)
Please consider using one message for plural disks and single disk.
I think it might simplify the code.
Something like the following message might work :
Cannot ${action} ${type}: The following disks: ${diskAliases} in lock status.
Please try again in a few minutes.
Line 517: {
Line 518: int numOfDisks = lockedDisksAliases.size();
Line 519: if (numOfDisks > 0)
Line 520: {
--
To view, visit http://gerrit.ovirt.org/8693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
