Allon Mureinik has posted comments on this change. Change subject: core: compensate on wrong object lead to NPE ......................................................................
Patch Set 6: Looks good to me, but someone else must approve (1 inline comment) Minor grramer issue in the commit message (sorry for missing it the 1st time round). Please fix it when you rebase. .................................................... Commit Message Line 3: AuthorDate: 2012-11-06 12:45:55 +0200 Line 4: Commit: Liron Aravot <lara...@redhat.com> Line 5: CommitDate: 2012-11-08 19:20:06 +0200 Line 6: Line 7: core: compensate on wrong object lead to NPE s/lead/leads/ Line 8: Line 9: Compensation during unlock vm is performed on the vm itself and not on Line 10: the vm dynamic data, which causes to NPE during compensation process as Line 11: there the defined DAO for the status update is per vm dynamic. -- To view, visit http://gerrit.ovirt.org/9074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
