Liron Aravot has uploaded a new change for review.

Change subject: core: compensate on wrong object lead to NPE
......................................................................

core: compensate on wrong object lead to NPE

Compensation during unlock vm is performed on the vm itself and not on
the vm dynamic data, which causes to NPE during compensation process.

Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/9074/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
index ac4edaf..e847747 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
@@ -226,7 +226,7 @@
 
             @Override
             public Void runInTransaction() {
-                compensationContext.snapshotEntityStatus(vm, vm.getstatus());
+                compensationContext.snapshotEntityStatus(vm.getDynamicData(), 
vm.getstatus());
                 UnLockVm(vm);
                 compensationContext.stateChanged();
                 return null;


--
To view, visit http://gerrit.ovirt.org/9074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to