Michael Pasternak has posted comments on this change.
Change subject: engine: Introduced force action in gluster peer detach command
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
you need to implement extra remove method that accepts Action
and delegate action.force to the backend
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 208: TransactionSupport.executeInNewTransaction(new
TransactionMethod<VdcReturnValueBase>() {
Line 209: @Override
Line 210: public VdcReturnValueBase runInTransaction() {
Line 211: return
Backend.getInstance().runInternalAction(VdcActionType.RemoveVds,
Line 212: new RemoveVdsParameters(oVirtId));
AddVdsCommand using RemoveVdsParameters ???
Line 213: }
Line 214: });
Line 215:
Line 216: if (!result.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/8894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2b8fa947cd6a6ece79ecfe00041f54e31e9e7ae
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
