ofri masad has posted comments on this change.

Change subject: core: Quota refactor - parameters
......................................................................


Patch Set 7: (6 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 595: 
Line 596:         switch (this.getActionType().getQuotaDependency()) {
Line 597:         case NONE:
Line 598:             return true;
Line 599:         case STORAGE:
Done
Line 600:             consumptionParameters.addAll(((QuotaStorageDependent) 
this).getQuotaStorageConsumptionParameters());
Line 601:             break;
Line 602:         case VDS:
Line 603:             consumptionParameters.addAll(((QuotaVdsDependent) 
this).getQuotaVdsConsumptionParameters());


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java
Line 1: package org.ovirt.engine.core.bll.quota;
Line 2: 
Line 3: import java.io.Serializable;
Line 4: 
Done
Line 5: public class InvalidQuotaParametersException extends RuntimeException 
implements Serializable {
Line 6:     private static final long serialVersionUID = -1759699263394287888L;
Line 7: 
Line 8:     public InvalidQuotaParametersException() {


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java
Line 36: 
Line 37:     public void setQuotaAction(QuotaAction quotaAction) {
Line 38:         this.quotaAction = quotaAction;
Line 39:     }
Line 40: 
Done
Line 41:     public abstract QuotaConsumptionParameter clone();
Line 42: 
Line 43:     public enum QuotaAction {
Line 44:         CONSUME, RELEASE


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java
Line 13:     private List<QuotaConsumptionParameter> parameters;
Line 14: 
Line 15:     private storage_pool storage_pool;
Line 16:     private ArrayList<String> canDoActionMessages;
Line 17:     private AuditLogableBase auditLogable;
Done
Line 18: 
Line 19:     public QuotaConsumptionParametersWrapper(storage_pool storage_pool,
Line 20:                                              ArrayList<String> 
canDoActionMessages,
Line 21:                                              AuditLogableBase 
auditLogable) {


Line 67:         }
Line 68:         return list;
Line 69:     }
Line 70: 
Line 71:     public ArrayList<String> getCanDoActionMessages() {
Done
Line 72:         return this.canDoActionMessages;
Line 73:     }
Line 74: 
Line 75:     public void setCanDoActionMessages(ArrayList<String> 
canDoActionMessages) {


Line 71:     public ArrayList<String> getCanDoActionMessages() {
Line 72:         return this.canDoActionMessages;
Line 73:     }
Line 74: 
Line 75:     public void setCanDoActionMessages(ArrayList<String> 
canDoActionMessages) {
Done
Line 76:         this.canDoActionMessages = canDoActionMessages;
Line 77:     }
Line 78: 
Line 79:     public AuditLogableBase getAuditLogable() {


--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to