Yair Zaslavsky has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 562: addInternalVdsParameters(consumptionParameters);
Line 563: break;
Line 564: }
Line 565: } catch (ClassCastException e) {
Line 566: log.error("Command: " + this.getClass().getName()
Is this exception swallowing correct?
Line 567: + ". Quota handling was expected - class does not
implement the expected interface");
Line 568: }
Line 569:
Line 570: QuotaConsumptionParametersWrapper
quotaConsumptionParametersWrapper;
Line 579: log.error("Command: " + this.getClass().getName()
Line 580: + ". Storage pool is not available for quota
calculation. ");
Line 581: }
Line 582:
Line 583: if (!consumptionParameters.isEmpty()) {
Why not use the trenary if?
Line 584: // TODO - implemented in next patch - return
QuotaManager.getInstance().consume(quotaConsumptionParametersWrapper);
Line 585: return true;
Line 586: } else {
Line 587: return true;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java
Line 3: import org.ovirt.engine.core.compat.ApplicationException;
Line 4:
Line 5: import java.io.Serializable;
Line 6:
Line 7: public class InvalidQuotaParametersException extends
ApplicationException implements Serializable {
I would prefer you do not extend ApplicationException.
Compat has to be minimal, and its classes should be removed (as much as
possible).
Can you please explain what did you try to achieve by extending it?
P.S - The fact we have this in other places in the code does not mean we don't
need to fix it, one day in the future ;)
Line 8: private static final long serialVersionUID = -1759699263394287888L;
Line 9:
Line 10: public InvalidQuotaParametersException() {
Line 11: }
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
