Gilad Chaplik has posted comments on this change.
Change subject: core: Quota refactor - parameters
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 596: switch (this.getActionType().getQuotaDependency()) {
Line 597: case NONE:
Line 598: return true;
Line 599: case STORAGE:
Line 600: consumptionParameters.addAll(((QuotaStorageDependent)
this).getQuotaStorageConsumptionParameters());
ZAS: what do you think if commandBase will implement QuotaStorageDependent and
the other one (with virtual empty impl), and we won't need to use casting?
Line 601: break;
Line 602: case VDS:
Line 603: consumptionParameters.addAll(((QuotaVdsDependent)
this).getQuotaVdsConsumptionParameters());
Line 604: break;
--
To view, visit http://gerrit.ovirt.org/8775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
