Keith Robertson has posted comments on this change. Change subject: tools: Get pg conf data from .pgpass (BZ732852) ......................................................................
Patch Set 2: Postgres tools do read .pgpass; however, they look for it in $HOME. IMO, it is dangerous to automatically place a .pgpass or append to a .pgpass in a user's home directory (especially root's). AFAIK, the installer was at one time doing exactly this. A better option would be to supply credentials to each of the PG tools (eg. pg_dump). This allows the oVirt ecosystem to control where the PG user, host, pass, etc. are stored. The SoS plug-in that dumps the PG DB does *not* make any assumptions on the existence of .pgpass. You must pass user, host, port, etc. in as arguments. -- To view, visit http://gerrit.ovirt.org/8927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eff0378e8515e5a399cb6700bc46fec698431ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
