Juan Hernandez has posted comments on this change. Change subject: tools: Get pg conf data from .pgpass (BZ732852) ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File src/rhev/logcollector.py Line 27: DEFAULT_SCRATCH_DIR='/tmp/logcollector' Line 28: DEFAULT_LOG_FILE='/var/log/ovirt-engine/engine-log-collector.log' Line 29: DEFAULT_TIME_SHIFT_FILE='time_diff.txt' Line 30: FILE_PG_PASS="/etc/ovirt-engine/.pgpass" Line 31: PGPASS_FILE_USER_LINE = "DB USER credentials" This ^ constant is not used, you may want to remove it. Line 32: PGPASS_FILE_ADMIN_LINE = "DB ADMIN credentials" Line 33: Line 34: Line 35: -- To view, visit http://gerrit.ovirt.org/8927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eff0378e8515e5a399cb6700bc46fec698431ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
