Moti Asayag has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
......................................................................
Patch Set 17: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java
Line 15: */
Line 16: public class GlusterVolumeAdvancedDetails implements Serializable {
Line 17:
Line 18: private static final long serialVersionUID = -1134758927239004412L;
Line 19:
you can remove this empty c'tor as is provided to you explicitly, if decided to
keep it, please maintain the class organized by:
* static members
* data members
* c'tor
* methods
* getters/setter
Line 20: public GlusterVolumeAdvancedDetails() {
Line 21: }
Line 22:
Line 23: private Guid volumeId;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeAdvancedDetailsParameters.java
Line 10: private static final long serialVersionUID = -1224829720081853632L;
Line 11:
Line 12: private String volumeName;
Line 13: private String brickName;
Line 14: private boolean detailsRequired = false;
this initialization is redundant as this is the default value.
Line 15:
Line 16: public GlusterVolumeAdvancedDetailsParameters(Guid clusterId,
Line 17: String volumeName,
Line 18: String brickName,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java
Line 6: * VDS parameter class with clusterId, volume name, brick name, details
required as parameter. <br>
Line 7: * This will be used directly by Get Gluster Volume Advanced Details
Query <br>
Line 8: */
Line 9: public class GlusterVolumeAdvancedDetailsVDSParameters extends
GlusterVolumeVDSParameters {
Line 10: private final Guid clusterId;
the final definition isn't mandatory here.
Line 11: private final String brickName;
Line 12: private final boolean detailsRequired;
Line 13:
Line 14: public GlusterVolumeAdvancedDetailsVDSParameters(Guid upServerId,
Line 24:
Line 25: public Guid getClusterId() {
Line 26: return clusterId;
Line 27: }
Line 28:
please modify to match java naming convention to isDetailsRequired()
Line 29: public boolean detailsRequired() {
Line 30: return detailsRequired;
Line 31: }
Line 32:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java
Line 77:
Line 78: public void setmStatus(StatusForXmlRpc mStatus) {
Line 79: this.mStatus = mStatus;
Line 80: }
Line 81:
please move this member definition to members definition (near private
StatusForXmlRpc mStatus)
Line 82: private GlusterVolumeAdvancedDetails volumeAdvancedDetails = new
GlusterVolumeAdvancedDetails();
Line 83:
Line 84: public GlusterVolumeStatusReturnForXmlRpc(Guid clusterId,
Map<String, Object> innerMap) {
Line 85: super(innerMap);
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
