Moti Asayag has posted comments on this change. Change subject: core: Make VDS a JPA entity ......................................................................
Patch Set 59: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/36600/59/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeStatistics.java: Line 103: if (!(obj instanceof NumaNodeStatistics)) { Line 104: return false; Line 105: } Line 106: NumaNodeStatistics other = (NumaNodeStatistics) obj; Line 107: return Objects.equals(cpuIdle, other.cpuIdle) && the operator should be on the beginning of each line :) Line 108: Objects.equals(cpuSys, other.cpuSys) && Line 109: Objects.equals(cpuUsagePercent, other.cpuUsagePercent) && Line 110: Objects.equals(cpuUser, other.cpuUser) && Line 111: Objects.equals(memFree, other.memFree) && -- To view, visit https://gerrit.ovirt.org/36600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d7aa140e20dcd9468ae1ed00af1df0cf3e8b9e6 Gerrit-PatchSet: 59 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
