Moti Asayag has posted comments on this change. Change subject: core: Make VDS a JPA entity ......................................................................
Patch Set 58: (1 comment) https://gerrit.ovirt.org/#/c/36600/58/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/DistanceUserType.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/DistanceUserType.java: Line 96: public int[] sqlTypes() { Line 97: return new int[] { Types.VARCHAR }; Line 98: } Line 99: Line 100: // format: (<index_id>, <distance>);*, for example: "0, 10; 2, 16" > It was copied from the Dao, so even this is an improvement. Can we do it in yes - it can be done in other patch. Line 101: private Map<Integer, Integer> getDistanceMap(String distance) { Line 102: Map<Integer, Integer> nodeDistance = new HashMap<>(); Line 103: if (StringUtils.isBlank(distance)) { Line 104: return nodeDistance; -- To view, visit https://gerrit.ovirt.org/36600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d7aa140e20dcd9468ae1ed00af1df0cf3e8b9e6 Gerrit-PatchSet: 58 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
