Moti Asayag has posted comments on this change. Change subject: core: Make VDS a JPA entity ......................................................................
Patch Set 56: Code-Review-1 (5 comments) there are unattended comments on patchset 43 + few on this patch. https://gerrit.ovirt.org/#/c/36600/56/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeCPUMap.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodeCPUMap.java: Line 25: Line 26: @Id Line 27: @Column(name = "id") Line 28: @Type(type = "org.ovirt.engine.core.dao.jpa.GuidUserType") Line 29: private Guid id = Guid.newGuid(); please move this to the c'tor Line 30: Line 31: @Column(name = "numa_node_id") Line 32: @Type(type = "org.ovirt.engine.core.dao.jpa.GuidUserType") Line 33: private Guid numaNodeId; https://gerrit.ovirt.org/#/c/36600/56/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java: Line 49: Line 50: @Id Line 51: @Column(name = "numa_node_id") Line 52: @Type(type = "org.ovirt.engine.core.dao.jpa.GuidUserType") Line 53: private Guid id = Guid.newGuid(); please move to the c'tor Line 54: Line 55: @Column(name = "vds_id") Line 56: @Type(type = "org.ovirt.engine.core.dao.jpa.GuidUserType") Line 57: private Guid vdsId; https://gerrit.ovirt.org/#/c/36600/56/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java: Line 92: Line 93: @EditableField Line 94: @Column(name = "protocol") Line 95: @Enumerated(EnumType.ORDINAL) Line 96: private VdsProtocol protocol = VdsProtocol.STOMP; c'tor ? Line 97: Line 98: @EditableOnVdsStatus Line 99: @Range(min = BusinessEntitiesDefinitions.NETWORK_MIN_LEGAL_PORT, Line 100: max = BusinessEntitiesDefinitions.NETWORK_MAX_LEGAL_PORT, https://gerrit.ovirt.org/#/c/36600/56/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDAOTest.java: Line 82: assertNotNull(result); Line 83: assertEquals(2, result.size()); Line 84: } Line 85: Line 86: // @Test please delete commented code Line 87: // public void testMassUpdateNumaNode() { Line 88: // List<VdsNumaNode> result = vdsNumaNodeDao.getAllVdsNumaNodeByVdsId(existingVds.getId()); Line 89: // assertNotNull(result); Line 90: // assertEquals(2, result.size()); https://gerrit.ovirt.org/#/c/36600/56/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 279: RETURN; Line 280: END; $procedure$ Line 281: LANGUAGE plpgsql; Line 282: Line 283: <<<<<<< HEAD ^^^ merge conflicts Line 284: Create or replace FUNCTION UpdateVdsDynamicStatus( Line 285: v_vds_guid UUID, Line 286: v_status INTEGER) Line 287: RETURNS VOID -- To view, visit https://gerrit.ovirt.org/36600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d7aa140e20dcd9468ae1ed00af1df0cf3e8b9e6 Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
