anmolbabu has posted comments on this change. Change subject: webadmin, engine : Error handling in geo-rep create ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42300/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java: Line 102: restartGlusterd > If you make restartGlusterd as an internal action, then you could call it h No but then again in that command we'll get VDSReturnValue(bcoz we need to run a vds command) which we need to convert to a VdcReturnValueBase and then propogate it. -- To view, visit https://gerrit.ovirt.org/42300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
