anmolbabu has posted comments on this change. Change subject: webadmin, engine : Error handling in geo-rep create ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42300/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java: Line 280: boolean succeeded = true; Line 281: List<String> errors = new ArrayList<String>(); Line 282: for (VdcReturnValueBase currentReturnValue : returnValues) { Line 283: boolean currentExecutionStatus = currentReturnValue.getSucceeded(); Line 284: succeeded &= currentExecutionStatus; > You are right although both logical and bitwise work same way on booleans, But shorthand is not allowed Line 285: if (!currentExecutionStatus) { Line 286: errors.addAll(currentReturnValue.getExecuteFailedMessages()); Line 287: } Line 288: } -- To view, visit https://gerrit.ovirt.org/42300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
