anmolbabu has uploaded a new change for review. Change subject: webadmin : Error handling in geo-rep create ......................................................................
webadmin : Error handling in geo-rep create The failure message of a command will be set in 1. canDoAction failure FrontendActionAsyncResult#getReturnValue#getCanDoActionMessages 2. Command failure from Vds FrontendActionAsyncResult#getReturnValue#getFault#getMessage 3. UI error handling assumed the only source of error to be 2 1, 2 and 3 necessiated to allow UI framework to handle erroneous conditions as it is capable of doing this conditional handling as in Frontend#handleActionResult Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230353 Signed-off-by: Anmol Babu <anb...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/42300/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java index 09d6b42..c49063e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java @@ -472,13 +472,11 @@ VolumeGeoRepListModel.this, false); } - } else { - createModel.setQueryFailureMessage(result.getReturnValue().getFault().getMessage()); } } }, this, - false); + true); } private void createGeoRepSession() { -- To view, visit https://gerrit.ovirt.org/42300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
