Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: saving the configuration on the shared domain ......................................................................
Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/42052/15//COMMIT_MSG Commit Message: Line 9: Creating an additional volume. Line 10: Packing the configuration files in a tar archive and Line 11: copying it to the additional volume. Line 12: Line 13: Change-Id: I1096aa6eabf97ac9cf9b032d0ac57fd8f63c2924 Bug-Url: http://bugzilla.redhat.com/1139793 https://gerrit.ovirt.org/#/c/42052/15/src/ovirt_hosted_engine_setup/heconflib.py File src/ovirt_hosted_engine_setup/heconflib.py: Line 40: ] Line 41: Line 42: Line 43: def _add_to_tar(tar, fname, content): Line 44: string = StringIO(unicode(content)) please use something different than string, it may confuse with the string python default module Line 45: info = tarfile.TarInfo(name=fname) Line 46: string.seek(0, os.SEEK_END) Line 47: info.size = string.tell() Line 48: string.seek(0, os.SEEK_SET) -- To view, visit https://gerrit.ovirt.org/42052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1096aa6eabf97ac9cf9b032d0ac57fd8f63c2924 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
