Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: saving the configuration on the shared domain ......................................................................
Patch Set 11: (1 comment) code looks ok to me. Documentation should be added at least to the library file. https://gerrit.ovirt.org/#/c/42052/11/src/ovirt_hosted_engine_setup/heconflib.py File src/ovirt_hosted_engine_setup/heconflib.py: Line 17: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 18: # Line 19: Line 20: Line 21: """ HEConf lib""" maybe some more text here may help understanding what's this module is supposed to do :-) Line 22: Line 23: Line 24: import os Line 25: import subprocess -- To view, visit https://gerrit.ovirt.org/42052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1096aa6eabf97ac9cf9b032d0ac57fd8f63c2924 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
