Eli Mesika has posted comments on this change. Change subject: webadmin: Adding external status to UI ......................................................................
Patch Set 23: (4 comments) https://gerrit.ovirt.org/#/c/40999/23/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/EntityAdditionalStatusColumn.java: Line 8: import org.ovirt.engine.ui.common.widget.table.column.AbstractSafeHtmlColumn; Line 9: import org.ovirt.engine.ui.webadmin.ApplicationResources; Line 10: import org.ovirt.engine.ui.webadmin.gin.AssetProvider; Line 11: Line 12: public class EntityAdditionalStatusColumn<S> extends AbstractSafeHtmlColumn<S> { > Why do you need this class, does any entity besides VDS has AdditionalStatu Yes, I am implementing currently external status support for storage domains Line 13: Line 14: protected final static ApplicationResources resources = AssetProvider.getResources(); Line 15: Line 16: protected ImageResource getStatusImage(ExternalStatus externalStatus) { Line 32: return SafeHtmlUtils.fromTrustedString(AbstractImagePrototype. Line 33: create(imageResource).getHTML()); Line 34: } Line 35: Line 36: protected SafeHtml getEntityValue(S s) { > abstract? Done Line 37: return null; Line 38: } Line 39: Line 40: protected SafeHtml getEntityTooltip(S object) { Line 36: protected SafeHtml getEntityValue(S s) { Line 37: return null; Line 38: } Line 39: Line 40: protected SafeHtml getEntityTooltip(S object) { > abstract? Done Line 41: return null; Line 42: } Line 43: Line 44: protected S getEntityObject(S object) { Line 40: protected SafeHtml getEntityTooltip(S object) { Line 41: return null; Line 42: } Line 43: Line 44: protected S getEntityObject(S object) { > Why do you need this method? implementation is in HostAdditionalStatusColumn and StorageDomainAdditionalStatusColumn (next set patch , not related to that one ....) I will make that abstract as well Line 45: return null; Line 46: } Line 47: Line 48: @Override -- To view, visit https://gerrit.ovirt.org/40999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99e7066176e70ec94f543aa1120bb355acad9b0a Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
