Tal Nisan has posted comments on this change. Change subject: webadmin: Adding external status to UI ......................................................................
Patch Set 1: (1 comment) Minor comment, aside for that looks ok https://gerrit.ovirt.org/#/c/42138/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java: Line 27: } Line 28: Line 29: @Override Line 30: public SafeHtml getEntityTooltip(StorageDomain object) { Line 31: Map<SafeHtml, String> imagesToText = getSafeHtmlStringMap(object); Isn't it better to just check storageDomain.getExternalStatus() != ExternalStatus.Ok instead of calling the whole method which will result in building HTML map of the images? Line 32: if (!imagesToText.isEmpty()) { Line 33: return MultiImageColumnHelper.getTooltip(imagesToText); Line 34: } Line 35: return null; -- To view, visit https://gerrit.ovirt.org/42138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I569130b66dadbcdce1cd32a5cd8a2a8d7a3501cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
