Muli Salem has posted comments on this change.
Change subject: core: Vms By Network Query
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File backend/manager/dbscripts/vms_sp.sql
Line 883: AS $procedure$
Line 884: BEGIN
Line 885: RETURN QUERY SELECT vms.*
Line 886: FROM vms
Line 887: INNER JOIN vds_groups
SP was removed.
Line 888: ON vms.vds_group_id = vds_groups.vds_group_id
Line 889: INNER JOIN network_cluster
Line 890: ON vds_groups.vds_group_id = network_cluster.cluster_id
Line 891: WHERE network_id = v_network_id
Line 887: INNER JOIN vds_groups
Line 888: ON vms.vds_group_id = vds_groups.vds_group_id
Line 889: INNER JOIN network_cluster
Line 890: ON vds_groups.vds_group_id = network_cluster.cluster_id
Line 891: WHERE network_id = v_network_id
SP was removed.
Line 892: AND NOT EXISTS (
Line 893: SELECT 1
Line 894: FROM vm_interface
Line 895: INNER JOIN network
Line 895: INNER JOIN network
Line 896: ON network.name = vm_interface.network_name
Line 897: INNER JOIN network_cluster
Line 898: ON network.id = network_cluster.network_id
Line 899: WHERE network_id = v_network_id
SP was removed.
Line 900: AND vms.vds_group_id = network_cluster.cluster_id
Line 901: AND vm_interface.vm_guid = vms.vm_guid);
Line 902: END; $procedure$
Line 903: LANGUAGE plpgsql;
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
Line 366: assertFalse(result.isEmpty());
Line 367: assertEquals(VM_COUNT, result.size());
Line 368: }
Line 369:
Line 370: private void assertEqualsIgnoreOrder(List<VM> existingVms,
List<VM> result) {
Done
Line 371: assertEquals(existingVms.size(), result.size());
Line 372: for (VM vm : existingVms) {
Line 373: assertTrue(result.contains(vm));
Line 374: }
--
To view, visit http://gerrit.ovirt.org/8529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8964c98e0cb90852e99ea40398ca1a28783cd4bd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
