Moti Asayag has posted comments on this change. Change subject: core: Vms By Network Queries (WIP) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/dbscripts/vms_sp.sql Line 889: INNER JOIN network_cluster Line 890: ON vds_groups.vds_group_id = network_cluster.cluster_id Line 891: WHERE network_id = v_network_id Line 892: AND NOT EXISTS ( Line 893: SELECT * you can replace the * with 1, as no need to specify all of the fields for existence check. Line 894: FROM vm_interface Line 895: INNER JOIN network Line 896: ON network.name = vm_interface.network_name Line 897: INNER JOIN network_cluster -- To view, visit http://gerrit.ovirt.org/8529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8964c98e0cb90852e99ea40398ca1a28783cd4bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
