Mike Kolesnik has posted comments on this change.
Change subject: core: Vms By Network Queries (WIP)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
Line 366: assertFalse(result.isEmpty());
Line 367: assertEquals(VM_COUNT, result.size());
Line 368: }
Line 369:
Line 370: private void assertEqualsIgnoreOrder(List<VM> existingVms,
List<VM> result) {
Can this code be extracted to a shared util class?
I see it is copied here from another test, and would probably be useful in many
more.
Line 371: assertEquals(existingVms.size(), result.size());
Line 372: for (VM vm : existingVms) {
Line 373: assertTrue(result.contains(vm));
Line 374: }
--
To view, visit http://gerrit.ovirt.org/8529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8964c98e0cb90852e99ea40398ca1a28783cd4bd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
