Simone Tiraboschi has posted comments on this change. Change subject: centralized manualSetupDispatcher code ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41399/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 715: details=e.detail Line 716: ) Line 717: ) Line 718: while not check_liveliness.manualSetupDispatcher(self, Line 719: '{fqdn}'): > its all the lines which reported in http://jenkins.ovirt.org/job/ovirt-host Ok, sorry :-) Could you please indent this way? while not check_liveliness.manualSetupDispatcher( self, '{fqdn}' ): Line 720: pass Line 721: Line 722: up = self._wait_host_ready( Line 723: engine_api, -- To view, visit https://gerrit.ovirt.org/41399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
