Simone Tiraboschi has posted comments on this change. Change subject: centralized manualSetupDispatcher code ......................................................................
Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/41399/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 606: while not added_to_cluster: Line 607: try: Line 608: conn = self.environment[ohostedcons.VDSMEnv.VDS_CLI] Line 609: net_info = netinfo.NetInfo(vds_info.capabilities(conn)) Line 610: bridge_port = \ you could avoid it Line 611: self.environment[ohostedcons.NetworkEnv.BRIDGE_IF] Line 612: if bridge_port in net_info.vlans: Line 613: self.logger.debug( Line 614: "Updating engine's management network to be vlanned" Line 617: self.logger.debug( Line 618: "Getting engine's management network via engine's APIs" Line 619: ) Line 620: mgmt_network = engine_api.networks.get( Line 621: name=self.environment[ you could avoid it Line 622: ohostedcons.NetworkEnv.BRIDGE_NAME] Line 623: ) Line 624: mgmt_network.set_vlan( Line 625: self._ovirtsdk_xml.params.VLAN(id=vlan_id) Line 644: cluster=cluster_name, Line 645: ) Line 646: ) Line 647: else: Line 648: cluster_l = \ you could avoid it Line 649: [c.get_name() for c in engine_api.clusters.list()] Line 650: cluster_name = ( Line 651: default_cluster_name if default_cluster_name in Line 652: cluster_l else cluster_l[0] Line 653: ) Line 654: cluster_name = self.dialog.queryString( Line 655: name='cluster_name', Line 656: note=_( Line 657: 'Enter the name of the cluster to which ' here too Line 658: 'you want to add the host (@VALUES@) ' Line 659: '[@DEFAULT@]: ' Line 660: ), Line 661: prompt=True, Line 715: details=e.detail Line 716: ) Line 717: ) Line 718: while not check_liveliness.manualSetupDispatcher(self, Line 719: '{fqdn}'): and also here Line 720: pass Line 721: Line 722: up = self._wait_host_ready( Line 723: engine_api, -- To view, visit https://gerrit.ovirt.org/41399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
