Simone Tiraboschi has posted comments on this change. Change subject: centralized manualSetupDispatcher code ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/41399/1/src/ovirt_hosted_engine_setup/check_liveliness.py File src/ovirt_hosted_engine_setup/check_liveliness.py: Line 49: ), Line 50: prompt=True, Line 51: validValues=(_('1'), _('2'), _('3'), _('4')), Line 52: default=_('1'), Line 53: caseSensitive=False) newline before ')' just to be consistent Line 54: if response == _('1').lower(): Line 55: if engine_fqdn is None: Line 56: if not base._wait_vm_destroyed(): Line 57: base._destroy_vm() Line 65: elif response == _('2').lower(): Line 66: base._destroy_vm() Line 67: base._create_vm() Line 68: elif response == _('3').lower(): Line 69: raise RuntimeError('Engine polling aborted by user') when the user is installing the OS, we are not really polling the engine Line 70: elif response == _('4').lower(): Line 71: base._destroy_vm() Line 72: raise RuntimeError( Line 73: _('VM destroyed and setup aborted by user') https://gerrit.ovirt.org/#/c/41399/1/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 711: details=e.detail Line 712: ) Line 713: ) Line 714: while not check_liveliness.manualSetupDispatcher(self, '{fqdn}'): Line 715: pass Maybe adding a general hint on failures could help Line 716: Line 717: up = self._wait_host_ready( Line 718: engine_api, Line 719: self.environment[ohostedcons.EngineEnv.APP_HOST_NAME] https://gerrit.ovirt.org/#/c/41399/1/src/plugins/ovirt-hosted-engine-setup/vm/runvm.py File src/plugins/ovirt-hosted-engine-setup/vm/runvm.py: Line 146: # connect from remote. Line 147: os_installed = False Line 148: while not os_installed: Line 149: try: Line 150: self._create_vm() If user selects 2 you are going to create twice Line 151: os_installed = check_liveliness.manualSetupDispatcher(self) Line 152: except socket.error as e: Line 153: self.logger.debug( Line 154: 'Error talking with VDSM (%s), reconnecting.' % str(e), -- To view, visit https://gerrit.ovirt.org/41399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360cf8e0c3c0ed9db1e9af3127ebd7881ed11d11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
