Allon Mureinik has posted comments on this change.
Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
Line 30: continue;
Line 31: }
Line 32:
Line 33: // Creating versions list
Line 34: List<String> versions = new ArrayList<String>();
since should be a final static constant - see comment in previous patch
Line 35: versions.add(Config.DefaultConfigurationVersion);
Line 36: for (Version version : Version.ALL) {
Line 37: versions.add(version.toString());
Line 38: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetConfigurationValuesQueryTest.java
Line 11: import
org.ovirt.engine.core.common.queries.GetConfigurationValueParameters;
Line 12: import org.ovirt.engine.core.utils.log.Log;
Line 13: import org.ovirt.engine.core.utils.log.LogFactory;
Line 14:
Line 15: public class GetConfigurationValuesQueryTest extends
AbstractUserQueryTest<GetConfigurationValueParameters,
GetConfigurationValueQuery<GetConfigurationValueParameters>> {
Since this test actually tests the relationship between
org.ovirt.engine.core.common.config.ConfigValues and
org.ovirt.engine.core.common.queries.ConfigurationValues, I'd move it to the
common package and rename it, or something down those line
Line 16: private static final Log log =
LogFactory.getLog(GetConfigurationValuesQueryTest.class);
Line 17: private static final Set<String> configValuesEnumNames =
getConfigValuesEnumNames();
Line 18:
Line 19: private static Set<String> getConfigValuesEnumNames() {
--
To view, visit http://gerrit.ovirt.org/8563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
