Roy Golan has posted comments on this change. Change subject: core: make EventQueue a CDI Singleton, dump jndi ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/40642/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java: Line 502: protected boolean isCinderStorageDomain() { Line 503: return getStorageDomain().getStorageType().isCinderDomain(); Line 504: } Line 505: Line 506: public EventQueue getEventQueue() { > you can change that to be protected Done Line 507: return eventQueue; Line 508: } https://gerrit.ovirt.org/#/c/40642/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java: Line 348: } Line 349: }); Line 350: } Line 351: Line 352: private EventQueue getEventQueue() { > is it preferred over having a static member of the eventqueue? yes. a static member would be harder to test. Line 353: return Injector.get(EventQueue.class); Line 354: } Line 355: Line 356: public Guid getPreferredHostId() { -- To view, visit https://gerrit.ovirt.org/40642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I966e995dd10b93d968cec135f10ab55f1bd729a7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
