Maor Lipchuk has posted comments on this change. Change subject: core: make EventQueue a CDI Singleton, dump jndi ......................................................................
Patch Set 4: (4 comments) looks good, minor comments https://gerrit.ovirt.org/#/c/40642/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java: Line 37: import org.ovirt.engine.core.compat.TransactionScopeOption; Line 38: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 39: import org.ovirt.engine.core.utils.transaction.TransactionMethod; Line 40: import org.ovirt.engine.core.utils.transaction.TransactionSupport; Line 41: please remove redundant line Line 42: Line 43: @NonTransactiveCommandAttribute(forceCompensation=true) Line 44: public class ActivateStorageDomainCommand<T extends StorageDomainPoolParametersBase> extends Line 45: StorageDomainCommandBase<T> { https://gerrit.ovirt.org/#/c/40642/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java: Line 121: getParameters().setVdsId(getVds().getId()); Line 122: VdcReturnValueBase returnVal = runInternalAction( Line 123: VdcActionType.ReconstructMasterDomain, Line 124: getParameters(), Line 125: cloneContextAndDetachFromParent()); Seems that this is not related to the patch Line 126: Line 127: boolean reconstructVerbExecuted = (returnVal.getActionReturnValue() != null) ? Line 128: (Boolean) returnVal.getActionReturnValue() : false; Line 129: https://gerrit.ovirt.org/#/c/40642/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java: Line 90: StorageDomainPoolParametersBase params = new StorageDomainPoolParametersBase(Guid.newGuid(), Guid.newGuid()); Line 91: DeactivateStorageDomainCommand<StorageDomainPoolParametersBase> cmd = Line 92: spy(new DeactivateStorageDomainCommand<StorageDomainPoolParametersBase>(params)); Line 93: Line 94: Please remove redundant line Line 95: @Before Line 96: public void setup() { Line 97: CommandMocks.mockDbFacade(cmd, dbFacade); Line 98: when(dbFacade.getStoragePoolDao()).thenReturn(storagePoolDAO); https://gerrit.ovirt.org/#/c/40642/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 46: private EventQueue eventQueue; Line 47: private static Map<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); Line 48: static final VDSStatus reportingVdsStatus = VDSStatus.Up; Line 49: Line 50: private static final Logger log = LoggerFactory.getLogger(IrsBrokerCommand.class); Not related to the patch Line 51: Line 52: /** Line 53: * process received domain monitoring information from a given vds if necessary (according to it's status Line 54: * and if it's a virtualization node). -- To view, visit https://gerrit.ovirt.org/40642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I966e995dd10b93d968cec135f10ab55f1bd729a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
