Roy Golan has posted comments on this change. Change subject: core: make EventQueue a CDI Singleton, dump jndi ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40642/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java: Line 37: import org.ovirt.engine.core.compat.TransactionScopeOption; Line 38: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 39: import org.ovirt.engine.core.utils.transaction.TransactionMethod; Line 40: import org.ovirt.engine.core.utils.transaction.TransactionSupport; Line 41: > please remove redundant line Done Line 42: Line 43: @NonTransactiveCommandAttribute(forceCompensation=true) Line 44: public class ActivateStorageDomainCommand<T extends StorageDomainPoolParametersBase> extends Line 45: StorageDomainCommandBase<T> { -- To view, visit https://gerrit.ovirt.org/40642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I966e995dd10b93d968cec135f10ab55f1bd729a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
