Moti Asayag has posted comments on this change.

Change subject: restapi: Support host upgrade
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/40463/10/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml:

Line 1847:       parameterType: Action
Line 1848:       signatures:
Line 1849:       - optionalArguments:
Line 1850:           action.image: xs:string
Line 1851:         description: upgrade vdsm and other packages of the 
specified host in the system
> No need for this description. For each context we have a general descriptio
Done
Line 1852: - name: /hosts/{host:id}/iscsidiscover|rel=iscsidiscover
Line 1853:   description: initiate the command to discover the iscsi targets 
and map the targets to the storage server connections
Line 1854:   request:
Line 1855:     body:


https://gerrit.ovirt.org/#/c/40463/10/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java:

Line 479:                                            new String[] { "VdsId" },
Line 480:                                            new Object[] { GUIDS[0] 
}));
Line 481: 
Line 482:         verifyActionResponse(resource.upgrade(new Action()));
Line 483:     }
> Would be better with image here as well
Done
Line 484: 
Line 485:     @Test
Line 486:     public void testCommitNetConfig() throws Exception {
Line 487:         
setUriInfo(setUpActionExpectations(VdcActionType.CommitNetworkChanges,


-- 
To view, visit https://gerrit.ovirt.org/40463
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78319727dd30fb38ced196afcb839ac9c1da0410
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to