Juan Hernandez has posted comments on this change. Change subject: restapi: Support host upgrade ......................................................................
Patch Set 8: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/40463/8/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1930: body: Line 1931: parameterType: Action Line 1932: signatures: Line 1933: - mandatoryArguments: {} Line 1934: optionalArguments: Avoid the empty mandatory arguments: signatures: - optionalArguments action:image: xs:string Line 1935: action.image: xs:string Line 1936: description: upgrade vdsm and other packages of the specified host in the system Line 1937: - name: /hosts/{host:id}/iscsidiscover|rel=iscsidiscover Line 1938: description: initiate the command to discover the iscsi targets and map the targets to the storage server connections https://gerrit.ovirt.org/#/c/40463/8/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java: Line 187: Line 188: @Override Line 189: public Response upgrade(Action action) { Line 190: VDS host = getEntity(); Line 191: UpgradeHostParameters params = new UpgradeHostParameters(host.getId()); No need to call getEntity() unless you want to explicitly check that the host exists, you can use "this.guid" instead. Line 192: if (action.isSetImage()) { Line 193: params.setoVirtIsoFile(action.getImage()); Line 194: } Line 195: -- To view, visit https://gerrit.ovirt.org/40463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78319727dd30fb38ced196afcb839ac9c1da0410 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
