Alona Kaplan has posted comments on this change. Change subject: webadmin: Enable 'Upgrade' action for all host types ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40706/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 438: setNumaSupportCommand(new UICommand("NumaSupport", this)); //$NON-NLS-1$ Line 439: getConfigureLocalStorageCommand().setAvailableInModes(ApplicationMode.VirtOnly); Line 440: getSelectAsSpmCommand().setAvailableInModes(ApplicationMode.VirtOnly); Line 441: Line 442: updateAvailableOvirtNodeUpgrades(); > The getSelectedItems() returns no value, so the result of that method isn't use getSelectedItem() if getSelectedItems() is empty. Line 443: updateActionAvailability(); Line 444: Line 445: getSearchNextPageCommand().setIsAvailable(true); Line 446: getSearchPreviousPageCommand().setIsAvailable(true); -- To view, visit https://gerrit.ovirt.org/40706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
