Moti Asayag has posted comments on this change. Change subject: webadmin: Enable 'Upgrade' action for all host types ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/40706/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java: Line 190: * an images which may upgrade the given host Line 191: * @param hostOs Line 192: * the examined host OS Line 193: * @return {@code true} if an update is available, else {@code false} Line 194: */ moved from the UI Line 195: public static boolean isUpdateAvailable(List<RpmVersion> isos, String hostOs) { Line 196: Line 197: String[] hostOsParts = hostOs.split("-"); Line 198: for (int i = 0; i < hostOsParts.length; i++) { https://gerrit.ovirt.org/#/c/40706/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 438: setNumaSupportCommand(new UICommand("NumaSupport", this)); //$NON-NLS-1$ Line 439: getConfigureLocalStorageCommand().setAvailableInModes(ApplicationMode.VirtOnly); Line 440: getSelectAsSpmCommand().setAvailableInModes(ApplicationMode.VirtOnly); Line 441: Line 442: updateAvailableOvirtNodeUpgrades(); The getSelectedItems() returns no value, so the result of that method isn't inclusive. How can it be solved ? Line 443: updateActionAvailability(); Line 444: Line 445: getSearchNextPageCommand().setIsAvailable(true); Line 446: getSearchPreviousPageCommand().setIsAvailable(true); -- To view, visit https://gerrit.ovirt.org/40706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
