Oved Ourfali has posted comments on this change. Change subject: webadmin: Enable 'Upgrade' action for all host types ......................................................................
Patch Set 5: Code-Review+1 (2 comments) minor comments. https://gerrit.ovirt.org/#/c/40706/5/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 927: Line 928: @DefaultStringValue("Host must be installed before upgrade.") Line 929: String hostMustBeInstalledBeforeUpgrade(); Line 930: Line 931: @DefaultStringValue("Are you sure you want to Upgrade the Host, running VM(s) will be migrated?") There are running VMs on this host. Are you sure you want to continue the upgrade process? Running VM(s) will be migrated to another host. Line 932: String areYouSureYouWantToUpgradeTheFollowingHostWithRunningVmsMsg(); Line 933: Line 934: @DefaultStringValue("Are you sure you want to Upgrade the Host?") Line 935: String areYouSureYouWantToUpgradeTheFollowingHostMsg(); Line 930: Line 931: @DefaultStringValue("Are you sure you want to Upgrade the Host, running VM(s) will be migrated?") Line 932: String areYouSureYouWantToUpgradeTheFollowingHostWithRunningVmsMsg(); Line 933: Line 934: @DefaultStringValue("Are you sure you want to Upgrade the Host?") Are you sure you want to Upgrade this Host? Line 935: String areYouSureYouWantToUpgradeTheFollowingHostMsg(); Line 936: Line 937: @DefaultStringValue("Testing in progress. It will take a few seconds. Please wait...") Line 938: String testingInProgressItWillTakeFewSecondsPleaseWaitMsg(); -- To view, visit https://gerrit.ovirt.org/40706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
