Dudi Maroshi has posted comments on this change. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ......................................................................
Patch Set 7: (8 comments) https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 22: import org.ovirt.engine.core.bll.snapshots.SnapshotsManager; Line 23: import org.ovirt.engine.core.bll.utils.IconUtils; Line 24: import org.ovirt.engine.core.bll.utils.PermissionSubject; Line 25: import org.ovirt.engine.core.bll.utils.VmDeviceUtils; Line 26: import org.ovirt.engine.core.bll.validator.IconValidator; > is this related? Done Line 27: import org.ovirt.engine.core.bll.validator.VmValidator; Line 28: import org.ovirt.engine.core.bll.validator.VmWatchdogValidator; Line 29: import org.ovirt.engine.core.common.AuditLogType; Line 30: import org.ovirt.engine.core.common.FeatureSupported; https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 38: import org.ovirt.engine.core.common.businessentities.GraphicsType; Line 39: import org.ovirt.engine.core.common.businessentities.GuestAgentStatus; Line 40: import org.ovirt.engine.core.common.businessentities.NumaTuneMode; Line 41: import org.ovirt.engine.core.common.businessentities.Snapshot; Line 42: import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType; > that's a merge problem as well I gues Done Line 43: import org.ovirt.engine.core.common.businessentities.StorageDomain; Line 44: import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; Line 45: import org.ovirt.engine.core.common.businessentities.UsbPolicy; Line 46: import org.ovirt.engine.core.common.businessentities.VDS; https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 424: VM_NUMA_PINNED_VDS_NODE_EMPTY(ErrorType.BAD_PARAMETERS), Line 425: VM_NUMA_NODE_PINNED_INDEX_ERROR(ErrorType.BAD_PARAMETERS), Line 426: VM_NUMA_NODE_MEMRORY_ERROR(ErrorType.BAD_PARAMETERS), Line 427: VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE(ErrorType.BAD_PARAMETERS), Line 428: VM_NUMA_NODE_MORE_NODES_THEN_CPUS(ErrorType.BAD_PARAMETERS), > THAN Done Line 429: CANNOT_PREVIEW_ACTIVE_SNAPSHOT(ErrorType.BAD_PARAMETERS), Line 430: VM_CANNOT_SUSPENDE_HAS_RUNNING_TASKS(ErrorType.CONFLICT), Line 431: VM_CANNOT_REMOVE_HAS_RUNNING_TASKS(ErrorType.CONFLICT), Line 432: VM_CANNOT_RUN_FROM_NETWORK_WITHOUT_NETWORK(ErrorType.CONFLICT), https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 766: VM_NUMA_PINNED_VDS_NODE_EMPTY=Cannot pin NUMA nodes when VDS NUMA nodes is empty. Line 767: VM_NUMA_NODE_PINNED_INDEX_ERROR=NUMA node pinned index error. Line 768: VM_NUMA_NODE_MEMRORY_ERROR=NUMA node memory error. Line 769: VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE=Preferred NUMA tune mode is allowed for a single pinned Virtual NUMA Node. Line 770: VM_NUMA_NODE_MORE_NODES_THEN_CPUS=Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores. > THAN Done Line 771: ACTION_TYPE_FAILED_TEMPLATE_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot export VM. Template ${TemplateName} does not exist on the export domain. if you want to export VM without its Template please use TemplateMustExists=false Line 772: ACTION_TYPE_FAILED_VM_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot ${action} ${type}. VM not exists in export domain Line 773: ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL=The Action ${action} ${type} is not supported for this Cluster or Data Center compatibility version Line 774: ACTION_TYPE_FAILED_MAX_CPU_PER_SOCKET=Cannot ${action} ${type}. Max number of cpu per socket exceeded Line 766: VM_NUMA_PINNED_VDS_NODE_EMPTY=Cannot pin NUMA nodes when VDS NUMA nodes is empty. Line 767: VM_NUMA_NODE_PINNED_INDEX_ERROR=NUMA node pinned index error. Line 768: VM_NUMA_NODE_MEMRORY_ERROR=NUMA node memory error. Line 769: VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE=Preferred NUMA tune mode is allowed for a single pinned Virtual NUMA Node. Line 770: VM_NUMA_NODE_MORE_NODES_THEN_CPUS=Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores. > than Done Line 771: ACTION_TYPE_FAILED_TEMPLATE_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot export VM. Template ${TemplateName} does not exist on the export domain. if you want to export VM without its Template please use TemplateMustExists=false Line 772: ACTION_TYPE_FAILED_VM_NOT_FOUND_ON_EXPORT_DOMAIN=Cannot ${action} ${type}. VM not exists in export domain Line 773: ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL=The Action ${action} ${type} is not supported for this Cluster or Data Center compatibility version Line 774: ACTION_TYPE_FAILED_MAX_CPU_PER_SOCKET=Cannot ${action} ${type}. Max number of cpu per socket exceeded https://gerrit.ovirt.org/#/c/39317/7/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3604: Line 3605: @DefaultStringValue("Preferred NUMA tune mode is allowed for a single pinned Virtual NUMA Node.") Line 3606: String VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE(); Line 3607: Line 3608: @DefaultStringValue("Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores.") > than Done Line 3609: String VM_NUMA_NODE_MORE_NODES_THEN_CPUS(); Line 3610: Line 3611: @DefaultStringValue("$detailMessage it is not a Hosted Engine host.") Line 3612: String VAR__DETAIL__NOT_HE_HOST(); Line 3605: @DefaultStringValue("Preferred NUMA tune mode is allowed for a single pinned Virtual NUMA Node.") Line 3606: String VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE(); Line 3607: Line 3608: @DefaultStringValue("Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores.") Line 3609: String VM_NUMA_NODE_MORE_NODES_THEN_CPUS(); > s/THEN/THAN Done Line 3610: Line 3611: @DefaultStringValue("$detailMessage it is not a Hosted Engine host.") Line 3612: String VAR__DETAIL__NOT_HE_HOST(); Line 3613: https://gerrit.ovirt.org/#/c/39317/7/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1374: PROVIDED_VM_ICON_HAS_INVALID_DIMENSIONS=Vm icon has invalid dimensions (${currentDimensions}). Allowed dimmension: ${allowedDimensions} Line 1375: DATA_SIZE_OF_PROVIDED_VM_ICON_TOO_LARGE=Data size of provided icon (${$currentSize}) is to big. Maximum allowd is ${$maxSize} Line 1376: VM_ICON_BASE64_PART_MALFORMED=Base64 part of vm icon is malformed. Line 1377: Line 1378: VM_NUMA_NODE_MORE_NODES_THEN_CPUS=Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores. > s/then/than Done -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
