Roy Golan has posted comments on this change. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ......................................................................
Patch Set 5: (4 comments) code styling comments only. https://gerrit.ovirt.org/#/c/39317/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 22: import org.ovirt.engine.core.bll.snapshots.SnapshotsManager; Line 23: import org.ovirt.engine.core.bll.utils.IconUtils; Line 24: import org.ovirt.engine.core.bll.utils.PermissionSubject; Line 25: import org.ovirt.engine.core.bll.utils.VmDeviceUtils; Line 26: import org.ovirt.engine.core.bll.validator.IconValidator; ? Line 27: import org.ovirt.engine.core.bll.validator.VmValidator; Line 28: import org.ovirt.engine.core.bll.validator.VmWatchdogValidator; Line 29: import org.ovirt.engine.core.common.AuditLogType; Line 30: import org.ovirt.engine.core.common.FeatureSupported; https://gerrit.ovirt.org/#/c/39317/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 897: // But there were no NUMA nodes at all!!! across the engine code, most of the cases we do a single block comment rather than inline. /* empty numa params. no change */ Line 901: if (isNumaChanged == true) missing curly braces Line 904: if (!emptyParamVmNumaNodes) {// An update to NUMA nodes : NUMAnodesCount = paramVmNumaNodes.size(); : } can we spare this assignment? its less code and for me its perfectly make sense to just check cpuCount < pramVmNumaNodes.size() -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
