Roy Golan has posted comments on this change. Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores) ......................................................................
Patch Set 7: (6 comments) https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 428: THEN THAN https://gerrit.ovirt.org/#/c/39317/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 770: THEN THAN Line 770: then than https://gerrit.ovirt.org/#/c/39317/7/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3608: then than Line 3605: @DefaultStringValue("Preferred NUMA tune mode is allowed for a single pinned Virtual NUMA Node.") Line 3606: String VM_NUMA_NODE_PREFERRED_NOT_PINNED_TO_SINGLE_NODE(); Line 3607: Line 3608: @DefaultStringValue("Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores.") Line 3609: String VM_NUMA_NODE_MORE_NODES_THEN_CPUS(); s/THEN/THAN Line 3610: Line 3611: @DefaultStringValue("$detailMessage it is not a Hosted Engine host.") Line 3612: String VAR__DETAIL__NOT_HE_HOST(); Line 3613: https://gerrit.ovirt.org/#/c/39317/7/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1374: PROVIDED_VM_ICON_HAS_INVALID_DIMENSIONS=Vm icon has invalid dimensions (${currentDimensions}). Allowed dimmension: ${allowedDimensions} Line 1375: DATA_SIZE_OF_PROVIDED_VM_ICON_TOO_LARGE=Data size of provided icon (${$currentSize}) is to big. Maximum allowd is ${$maxSize} Line 1376: VM_ICON_BASE64_PART_MALFORMED=Base64 part of vm icon is malformed. Line 1377: Line 1378: VM_NUMA_NODE_MORE_NODES_THEN_CPUS=Cannot ${action} ${type}. Assigned ${numaNodes} NUMA nodes for ${cpus} CPU cores. Cannot assign more NUMA nodes then CPU cores. s/then/than -- To view, visit https://gerrit.ovirt.org/39317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
