Oved Ourfali has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/39374/10/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java: Line 26: XmlRpcObjectDescriptor.toStringBuilder(mInfo, builder); Line 27: } else { Line 28: builder.append("Pending Response"); Line 29: } Line 30: return builder.toString(); Consider using ToStringBuilder. See my recent patch. Line 31: } Line 32: Line 33: public OneImageInfoReturnForXmlRpc(Map<String, Object> innerMap) { Line 34: super(innerMap); -- To view, visit https://gerrit.ovirt.org/39374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458143387f89a5d55bda5f1d4f9d44be4f7fb197 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
